feat(remote): proxy workspace ops and normalize WSL paths#155
feat(remote): proxy workspace ops and normalize WSL paths#155Dimillian merged 3 commits intoDimillian:mainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d910efbaa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the Codex P2 inline note: is now normalized via the same WSL UNC path normalization used for workspace/image paths before proxying in remote mode. |
slkzgm
force-pushed
the
pr6-remote-workspace-ops-client-v2
branch
from
6308582 to
9e1973f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6301d40d08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if remote_backend::is_remote_mode(&*state).await { | ||
| let path = remote_backend::normalize_path_for_remote(path); | ||
| let codex_bin = codex_bin.map(remote_backend::normalize_path_for_remote); | ||
| let response = remote_backend::call_remote( | ||
| &*state, |
There was a problem hiding this comment.
In remote mode this early return skips updating state.workspaces, but git commands like get_git_status (src-tauri/src/git.rs) still resolve workspaces from that local cache. After adding a workspace in remote mode, those commands will now return “workspace not found,” so the git status/diff UI won’t refresh for the new workspace. Consider mirroring the remote response into state.workspaces (or proxying git commands) so the local cache stays consistent.
Useful? React with 👍 / 👎.
2 participants
Part of the optional remote backend mode RFC (#54).
This PR builds on the remote proxy work merged in #121.
What
backendMode=remote.\\wsl$\\<distro>\\.../\\wsl.localhost\\<distro>\\...can be converted to WSL paths (/home/...) before being sent to the daemon.Why
In remote mode the daemon owns the filesystem and workspace registry. The app needs a thin forwarding layer so the existing UI flows (add/connect/list workspaces, file listing) work without changing default local behavior.
Notes
backendMode=localremains unchanged).Validation
npm cinpm run typechecknpm run buildRust compilation/tests require platform WebKitGTK deps on Linux; CI should cover this.